From: Sachin Prabhu <sprabhu@redhat.com>
Date: Wed, 28 Mar 2012 17:07:08 +0000 (+0100)
Subject: Remove unnecessary check for NULL in password parser
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1023807458b6365e28c66095648e1b66e04a4259;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

Remove unnecessary check for NULL in password parser

The password parser has an unnecessary check for a NULL value which
triggers warnings in source checking tools. The code contains artifacts
from the old parsing code which are no longer required.

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 302a15c505a9..0511fdbdf92e 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1565,8 +1565,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
 
 			/* Obtain the value string */
 			value = strchr(data, '=');
-			if (value != NULL)
-				*value++ = '\0';
+			value++;
 
 			/* Set tmp_end to end of the string */
 			tmp_end = (char *) value + strlen(value);