From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 3 Feb 2015 14:05:26 +0000 (-0300)
Subject: [media] sp2: Delete an unnecessary check before the function call "kfree"
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=0ea4bce7c09e29dc0a1891f6c7ba17794ec5f2b1;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

[media] sp2: Delete an unnecessary check before the function call "kfree"

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---

diff --git a/drivers/media/dvb-frontends/sp2.c b/drivers/media/dvb-frontends/sp2.c
index cc1ef966f99f..8fd42767e263 100644
--- a/drivers/media/dvb-frontends/sp2.c
+++ b/drivers/media/dvb-frontends/sp2.c
@@ -413,11 +413,8 @@ static int sp2_remove(struct i2c_client *client)
 	struct sp2 *s = i2c_get_clientdata(client);
 
 	dev_dbg(&client->dev, "\n");
-
 	sp2_exit(client);
-	if (s != NULL)
-		kfree(s);
-
+	kfree(s);
 	return 0;
 }