From: Axel Lin Date: Mon, 22 Apr 2013 10:22:49 +0000 (+0800) Subject: regulator: palmas: Fix off-by-one for ramp_delay and register value mapping X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=0ea34b578647e60ad4e06c9ba29829dc07c5264a;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git regulator: palmas: Fix off-by-one for ramp_delay and register value mapping Datasheet says: Time Step (TSTEP) selection, when changing the output voltage, the new value is reached through successive voltage steps (if not bypassed). The equivalent programmable slew rate of the output voltage is: TSTEP[1:0]: 00 Jump (no slope control) TSTEP[1:0]: 01 10mV/us TSTEP[1:0]: 10 5mV/us (default) TSTEP[1:0]: 11 2.5mV/us Signed-off-by: Axel Lin Acked-by: Laxman Dewangan Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 552ed514ba25..1be9c3216974 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c @@ -447,9 +447,9 @@ static int palmas_smps_set_ramp_delay(struct regulator_dev *rdev, if (ramp_delay <= 0) reg = 0; - else if (ramp_delay < 2500) + else if (ramp_delay <= 2500) reg = 3; - else if (ramp_delay < 5000) + else if (ramp_delay <= 5000) reg = 2; else reg = 1;