From: Dan Carpenter <error27@gmail.com>
Date: Sat, 26 Feb 2011 12:48:12 +0000 (+0300)
Subject: staging: gma500: fix some swapped gotos
X-Git-Tag: MMI-PSA29.97-13-9~20521^2~351
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=0e83f46d3869a5255a04b875bb885bd141a609ef;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

staging: gma500: fix some swapped gotos

These gotos were swapped.  In the original code, the first would result
in a NULL dereference and the second would result in a memory leak.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/gma500/psb_fb.c b/drivers/staging/gma500/psb_fb.c
index 94d845740313..f67f53b12937 100644
--- a/drivers/staging/gma500/psb_fb.c
+++ b/drivers/staging/gma500/psb_fb.c
@@ -460,7 +460,7 @@ static int psbfb_create(struct psb_fbdev *fbdev,
 	if (!fb) {
 		DRM_ERROR("failed to allocate fb.\n");
 		ret = -ENOMEM;
-		goto out_err0;
+		goto out_err1;
 	}
 	psbfb = to_psb_fb(fb);
 	psbfb->size = size;
@@ -468,7 +468,7 @@ static int psbfb_create(struct psb_fbdev *fbdev,
 	info = framebuffer_alloc(sizeof(struct psb_fbdev), device);
 	if (!info) {
 		ret = -ENOMEM;
-		goto out_err1;
+		goto out_err0;
 	}
 
 	info->par = fbdev;