From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 12 Dec 2014 19:28:10 +0000 (+0300)
Subject: ALSA: oxfw: fix detect_loud_models() return value
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=0d3aba30b755fe9ccaf390f0e71f6fb9fd55bd87;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

ALSA: oxfw: fix detect_loud_models() return value

This code causes a static checker warning:

	sound/firewire/oxfw/oxfw.c:46 detect_loud_models()
	warn: signedness bug returning '(-2)'

The detect_loud_models() function should return false on falure, so that
we don't try to set up the loud code for hardware that doesn't support
it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c
index cf1d0b55e827..60e5cad0531a 100644
--- a/sound/firewire/oxfw/oxfw.c
+++ b/sound/firewire/oxfw/oxfw.c
@@ -43,7 +43,7 @@ static bool detect_loud_models(struct fw_unit *unit)
 	err = fw_csr_string(unit->directory, CSR_MODEL,
 			    model, sizeof(model));
 	if (err < 0)
-		return err;
+		return false;
 
 	for (i = 0; i < ARRAY_SIZE(models); i++) {
 		if (strcmp(models[i], model) == 0)