From: Dan Carpenter Date: Thu, 15 Aug 2013 05:53:38 +0000 (+0300) Subject: xfs: check for underflow in xfs_iformat_fork() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=0d0ab120d1fe90fcc73a2bfff3945bea636b3025;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git xfs: check for underflow in xfs_iformat_fork() The "di_size" variable comes from the disk and it's a signed 64 bit. We check the upper limit but we should check for negative numbers as well. Signed-off-by: Dan Carpenter Reviewed-by: Ben Myers Signed-off-by: Ben Myers --- diff --git a/fs/xfs/xfs_inode_fork.c b/fs/xfs/xfs_inode_fork.c index 2b60a5a2ae53..02f1083955bb 100644 --- a/fs/xfs/xfs_inode_fork.c +++ b/fs/xfs/xfs_inode_fork.c @@ -167,7 +167,8 @@ xfs_iformat_fork( } di_size = be64_to_cpu(dip->di_size); - if (unlikely(di_size > XFS_DFORK_DSIZE(dip, ip->i_mount))) { + if (unlikely(di_size < 0 || + di_size > XFS_DFORK_DSIZE(dip, ip->i_mount))) { xfs_warn(ip->i_mount, "corrupt inode %Lu (bad size %Ld for local inode).", (unsigned long long) ip->i_ino,