From: H Hartley Sweeten <hsweeten@visionengravers.com>
Date: Mon, 2 May 2016 17:11:43 +0000 (-0700)
Subject: staging: comedi: mite: use prefered form for passing a struct size
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=0bdb1288fae54833367f00a1c76244a30731b8c9;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

staging: comedi: mite: use prefered form for passing a struct size

Add a local variable to mite_buf_change() so that the prefered
form of passing a struct size, sizeof(*p), can be used.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
index 8b0f875972f5..650c6039df39 100644
--- a/drivers/staging/comedi/drivers/mite.c
+++ b/drivers/staging/comedi/drivers/mite.c
@@ -473,6 +473,7 @@ int mite_buf_change(struct mite_ring *ring,
 		    struct comedi_subdevice *s)
 {
 	struct comedi_async *async = s->async;
+	struct mite_dma_desc *descs;
 	unsigned int n_links;
 
 	mite_free_dma_descs(ring);
@@ -482,15 +483,15 @@ int mite_buf_change(struct mite_ring *ring,
 
 	n_links = async->prealloc_bufsz >> PAGE_SHIFT;
 
-	ring->descs =
-	    dma_alloc_coherent(ring->hw_dev,
-			       n_links * sizeof(struct mite_dma_desc),
-			       &ring->dma_addr, GFP_KERNEL);
-	if (!ring->descs) {
+	descs = dma_alloc_coherent(ring->hw_dev,
+				   n_links * sizeof(*descs),
+				   &ring->dma_addr, GFP_KERNEL);
+	if (!descs) {
 		dev_err(s->device->class_dev,
 			"mite: ring buffer allocation failed\n");
 		return -ENOMEM;
 	}
+	ring->descs = descs;
 	ring->n_links = n_links;
 
 	return mite_init_ring_descriptors(ring, s, n_links << PAGE_SHIFT);