From: Russell King - ARM Linux Date: Mon, 5 Mar 2012 20:15:11 +0000 (+0000) Subject: dmaengine: mv_xor: remove write-only is_complete_cookie X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=08714f60b0fc6ea3a060b69b32e77139f14e6045;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git dmaengine: mv_xor: remove write-only is_complete_cookie mv_xor's is_complete_cookie is only ever written to, but never read. This is silly, remove the write-only structure member. Signed-off-by: Russell King Tested-by: Linus Walleij Reviewed-by: Linus Walleij Acked-by: Jassi Brar [imx-sdma.c & mxs-dma.c] Tested-by: Shawn Guo Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index e779b434af45..ad7d03fe4cb4 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -826,7 +826,6 @@ static enum dma_status mv_xor_status(struct dma_chan *chan, last_used = chan->cookie; last_complete = mv_chan->completed_cookie; - mv_chan->is_complete_cookie = cookie; dma_set_tx_state(txstate, last_complete, last_used, 0); ret = dma_async_is_complete(cookie, last_complete, last_used); diff --git a/drivers/dma/mv_xor.h b/drivers/dma/mv_xor.h index 977b592e976b..da04ac23def3 100644 --- a/drivers/dma/mv_xor.h +++ b/drivers/dma/mv_xor.h @@ -109,7 +109,6 @@ struct mv_xor_chan { #ifdef USE_TIMER unsigned long cleanup_time; u32 current_on_last_cleanup; - dma_cookie_t is_complete_cookie; #endif };