From: Theodore Ts'o Date: Sun, 21 Jun 2015 02:50:33 +0000 (-0400) Subject: ext4: call sync_blockdev() before invalidate_bdev() in put_super() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=05bd563daf991a17af6143e0f7daf68a64572337;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git ext4: call sync_blockdev() before invalidate_bdev() in put_super() commit 89d96a6f8e6491f24fc8f99fd6ae66820e85c6c1 upstream. Normally all of the buffers will have been forced out to disk before we call invalidate_bdev(), but there will be some cases, where a file system operation was aborted due to an ext4_error(), where there may still be some dirty buffers in the buffer cache for the device. So try to force them out to memory before calling invalidate_bdev(). This fixes a warning triggered by generic/081: WARNING: CPU: 1 PID: 3473 at /usr/projects/linux/ext4/fs/block_dev.c:56 __blkdev_put+0xb5/0x16f() Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 19d38cbea61..080f07e5960 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -857,6 +857,7 @@ static void ext4_put_super(struct super_block *sb) dump_orphan_list(sb, sbi); J_ASSERT(list_empty(&sbi->s_orphan)); + sync_blockdev(sb->s_bdev); invalidate_bdev(sb->s_bdev); if (sbi->journal_bdev && sbi->journal_bdev != sb->s_bdev) { /*