From: Tomi Valkeinen Date: Thu, 13 Dec 2012 10:08:21 +0000 (+0200) Subject: OMAPFB: use devm_kzalloc to allocate omapfb2_device X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=057eeaee6803dafbbf2f79345643530e731ba7cb;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git OMAPFB: use devm_kzalloc to allocate omapfb2_device Use devm_kzalloc to allocate omapfb2_device. This fixes possible memory leak: drivers/video/omap2/omapfb/omapfb-main.c:2553 omapfb_probe() warn: possible memory leak of 'fbdev' Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index 4fa9487a872..477a20817d0 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -1868,7 +1868,6 @@ static void omapfb_free_resources(struct omapfb2_device *fbdev) } dev_set_drvdata(fbdev->dev, NULL); - kfree(fbdev); } static int omapfb_create_framebuffers(struct omapfb2_device *fbdev) @@ -2413,7 +2412,8 @@ static int __init omapfb_probe(struct platform_device *pdev) goto err0; } - fbdev = kzalloc(sizeof(struct omapfb2_device), GFP_KERNEL); + fbdev = devm_kzalloc(&pdev->dev, sizeof(struct omapfb2_device), + GFP_KERNEL); if (fbdev == NULL) { r = -ENOMEM; goto err0;