From: Frans Klaver Date: Wed, 14 Jan 2015 08:15:40 +0000 (+0100) Subject: power: reset: ltc2952: drop empty suspend/resume functions X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=0428c40d4c448f5dc63b0f76de14fa0affa7aa2f;p=GitHub%2FLineageOS%2FG12%2Fandroid_kernel_amlogic_linux-4.9.git power: reset: ltc2952: drop empty suspend/resume functions Documentation/SubmittingDrivers suggests these be implemented even when they do nothing. On the other hand, the platform code calls these functions 'legacy'. Suspend and resume operations should go into a pm_ops structure, pointed at by the driver's pm field. This approach would lead to a lot of boiler plate, while achieving nothing. Drop the functions instead. Signed-off-by: Frans Klaver Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/reset/ltc2952-poweroff.c b/drivers/power/reset/ltc2952-poweroff.c index 8c936ed555c1..d29948762ceb 100644 --- a/drivers/power/reset/ltc2952-poweroff.c +++ b/drivers/power/reset/ltc2952-poweroff.c @@ -184,17 +184,6 @@ static void ltc2952_poweroff_kill(void) gpiod_set_value(ltc2952_data->gpio_kill, 1); } -static int ltc2952_poweroff_suspend(struct platform_device *pdev, - pm_message_t state) -{ - return -ENOSYS; -} - -static int ltc2952_poweroff_resume(struct platform_device *pdev) -{ - return -ENOSYS; -} - static void ltc2952_poweroff_default(struct ltc2952_poweroff *data) { data->wde_interval = ktime_set(0, 300L*1E6L); @@ -322,8 +311,6 @@ static struct platform_driver ltc2952_poweroff_driver = { .name = "ltc2952-poweroff", .of_match_table = of_ltc2952_poweroff_match, }, - .suspend = ltc2952_poweroff_suspend, - .resume = ltc2952_poweroff_resume, }; module_platform_driver(ltc2952_poweroff_driver);