From: Colin Ian King <colin.king@canonical.com>
Date: Mon, 27 Mar 2017 17:51:18 +0000 (+0100)
Subject: HID: sony: remove redundant check for -ve err
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=040fc001765d374776353cb4f8b03ea7fa41e3cd;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

HID: sony: remove redundant check for -ve err

err is being checked for failure each time it is being updated
so this err check is totally redundant and can be removed

Detected with CoverityScan, CID#1420665 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index e90ce63897df..43213d6ff2d1 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2654,9 +2654,6 @@ static int sony_input_configured(struct hid_device *hdev,
 		ret = 0;
 	}
 
-	if (ret < 0)
-		goto err_stop;
-
 	if (sc->quirks & SONY_LED_SUPPORT) {
 		ret = sony_leds_init(sc);
 		if (ret < 0)