regulator: pv88090: Fix array out-of-bounds access
authorAxel Lin <axel.lin@ingics.com>
Tue, 19 Feb 2019 10:00:02 +0000 (18:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:16 +0000 (10:24 +0100)
[ Upstream commit a5455c9159414748bed4678184bf69989a4f7ba3 ]

Fix off-by-one while iterating current_limits array.
The valid index should be 0 ~ n_current_limits -1.

Fixes: c90456e36d9c ("regulator: pv88090: new regulator driver")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/pv88090-regulator.c

index 42164117535298bc011378bad23f221e8063c566..789652c9b01423f69eb4c77ab78837466b063d76 100644 (file)
@@ -157,7 +157,7 @@ static int pv88090_set_current_limit(struct regulator_dev *rdev, int min,
        int i;
 
        /* search for closest to maximum */
-       for (i = info->n_current_limits; i >= 0; i--) {
+       for (i = info->n_current_limits - 1; i >= 0; i--) {
                if (min <= info->current_limits[i]
                        && max >= info->current_limits[i]) {
                        return regmap_update_bits(rdev->regmap,