ANDROID: sdcardfs: remove unneeded null check
authorDaniel Rosenberg <drosen@google.com>
Tue, 21 Mar 2017 23:29:13 +0000 (16:29 -0700)
committerDaniel Rosenberg <drosen@google.com>
Tue, 30 Jan 2018 03:40:07 +0000 (19:40 -0800)
As pointed out by checkpatch, these functions already
handle null inputs, so the checks are not needed.

Signed-off-by: Daniel Rosenberg <drosen@google.com>
Bug: 35331000
Change-Id: I189342f032dfcefee36b27648bb512488ad61d20

fs/sdcardfs/lookup.c
fs/sdcardfs/packagelist.c
fs/sdcardfs/super.c

index 6b450c48e5d3ae7718024489d1a7c1f236cbb686..6de2747b636abe43210cad5fd68709af8b1b5afa 100644 (file)
@@ -36,8 +36,7 @@ int sdcardfs_init_dentry_cache(void)
 
 void sdcardfs_destroy_dentry_cache(void)
 {
-       if (sdcardfs_dentry_cachep)
-               kmem_cache_destroy(sdcardfs_dentry_cachep);
+       kmem_cache_destroy(sdcardfs_dentry_cachep);
 }
 
 void free_dentry_private_data(struct dentry *dentry)
index 3df39a715a584770af1c25dde70346c8b5f5bedd..cadb5fa231c11857443a97d276d0f428df63d1ba 100644 (file)
@@ -889,6 +889,5 @@ void packagelist_exit(void)
 {
        configfs_sdcardfs_exit();
        packagelist_destroy();
-       if (hashtable_entry_cachep)
-               kmem_cache_destroy(hashtable_entry_cachep);
+       kmem_cache_destroy(hashtable_entry_cachep);
 }
index a4629f20812e66121e6762c847092b8ed23cd60b..7d3c331379f59c68779ed9207a1afe479b25faf1 100644 (file)
@@ -222,8 +222,7 @@ int sdcardfs_init_inode_cache(void)
 /* sdcardfs inode cache destructor */
 void sdcardfs_destroy_inode_cache(void)
 {
-       if (sdcardfs_inode_cachep)
-               kmem_cache_destroy(sdcardfs_inode_cachep);
+       kmem_cache_destroy(sdcardfs_inode_cachep);
 }
 
 /*