tracing: Remove redundant raw_init callbacks
authorLi Zefan <lizf@cn.fujitsu.com>
Mon, 24 May 2010 08:24:52 +0000 (16:24 +0800)
committerSteven Rostedt <rostedt@goodmis.org>
Mon, 28 Jun 2010 21:12:53 +0000 (17:12 -0400)
raw_init callback is optional.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4BFA37D4.7070500@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_export.c
kernel/trace/trace_kprobe.c

index 8536e2a659690f5aa82935ec20eb7d8fa74e3b5f..4ba44deaac259d05fb67d5d31e8ce5371844a414 100644 (file)
@@ -125,12 +125,6 @@ ftrace_define_fields_##name(struct ftrace_event_call *event_call)  \
 
 #include "trace_entries.h"
 
-static int ftrace_raw_init_event(struct ftrace_event_call *call)
-{
-       INIT_LIST_HEAD(&call->class->fields);
-       return 0;
-}
-
 #undef __entry
 #define __entry REC
 
@@ -158,7 +152,7 @@ static int ftrace_raw_init_event(struct ftrace_event_call *call)
 struct ftrace_event_class event_class_ftrace_##call = {                        \
        .system                 = __stringify(TRACE_SYSTEM),            \
        .define_fields          = ftrace_define_fields_##call,          \
-       .raw_init               = ftrace_raw_init_event,                \
+       .fields                 = LIST_HEAD_INIT(event_class_ftrace_##call.fields),\
 };                                                                     \
                                                                        \
 struct ftrace_event_call __used                                                \
index f52b5f50299dae5cc74dfe807054cd7d0e3f875e..3b831d8e201e95697eab6aa181391c8d70502f24 100644 (file)
@@ -1214,11 +1214,6 @@ static void probe_event_disable(struct ftrace_event_call *call)
        }
 }
 
-static int probe_event_raw_init(struct ftrace_event_call *event_call)
-{
-       return 0;
-}
-
 #undef DEFINE_FIELD
 #define DEFINE_FIELD(type, item, name, is_signed)                      \
        do {                                                            \
@@ -1486,15 +1481,12 @@ static int register_probe_event(struct trace_probe *tp)
        int ret;
 
        /* Initialize ftrace_event_call */
+       INIT_LIST_HEAD(&call->class->fields);
        if (probe_is_return(tp)) {
-               INIT_LIST_HEAD(&call->class->fields);
                call->event.funcs = &kretprobe_funcs;
-               call->class->raw_init = probe_event_raw_init;
                call->class->define_fields = kretprobe_event_define_fields;
        } else {
-               INIT_LIST_HEAD(&call->class->fields);
                call->event.funcs = &kprobe_funcs;
-               call->class->raw_init = probe_event_raw_init;
                call->class->define_fields = kprobe_event_define_fields;
        }
        if (set_print_fmt(tp) < 0)