ALSA: info: Use kvzalloc() for a temporary write buffer

We used to use kmalloc (more exactly, krealloc()) for creating and
growing the temporary buffer for text proc write.  It can grow up to
16kB, and it's already a bit doubtful whether it's always safe to use
kmalloc().  With the recent addition of kvmalloc(), we can have a
better chance for succeed of memory allocation, so let's switch to
that new API.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/core/info.c b/sound/core/info.c
index 8ab72e0f593292ac91aea0b06b70d89fc084bd3c..fc14ebe751d8fda95933147346b29b863f4300a2 100644 (file)
--- a/sound/core/info.c
+++ b/sound/core/info.c
@@ -344,12 +344,12 @@ static ssize_t snd_info_text_entry_write(struct file *file,
                }
        }
        if (next > buf->len) {
-               char *nbuf = krealloc(buf->buffer, PAGE_ALIGN(next),
-                                     GFP_KERNEL | __GFP_ZERO);
+               char *nbuf = kvzalloc(PAGE_ALIGN(next), GFP_KERNEL);
                if (!nbuf) {
                        err = -ENOMEM;
                        goto error;
                }
+               kvfree(buf->buffer);
                buf->buffer = nbuf;
                buf->len = PAGE_ALIGN(next);
        }
@@ -427,7 +427,7 @@ static int snd_info_text_entry_release(struct inode *inode, struct file *file)
        single_release(inode, file);
        kfree(data->rbuffer);
        if (data->wbuffer) {
-               kfree(data->wbuffer->buffer);
+               kvfree(data->wbuffer->buffer);
                kfree(data->wbuffer);
        }