dm raid: avoid superfluous memory barriers on static metadata
authorHeinz Mauelshagen <heinzm@redhat.com>
Wed, 15 Jun 2016 16:39:17 +0000 (18:39 +0200)
committerMike Snitzer <snitzer@redhat.com>
Mon, 18 Jul 2016 19:37:17 +0000 (15:37 -0400)
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-raid.c

index 248053d845283d49b6000fd98cbc74dc4c096672..4bf7747a25a9a59701a874545c616e7823d1858a 100644 (file)
@@ -366,14 +366,12 @@ static bool rs_is_reshapable(struct raid_set *rs)
 /* Return true, if raid set in @rs is recovering */
 static bool rs_is_recovering(struct raid_set *rs)
 {
-       smp_rmb();
        return rs->md.recovery_cp != MaxSector;
 }
 
 /* Return true, if raid set in @rs is reshaping */
 static bool rs_is_reshaping(struct raid_set *rs)
 {
-       smp_rmb();
        return rs->md.reshape_position != MaxSector;
 }
 
@@ -1484,7 +1482,6 @@ static int rs_check_takeover(struct raid_set *rs)
        struct mddev *mddev = &rs->md;
        unsigned int near_copies;
 
-       smp_rmb();
        if (rs->md.degraded) {
                rs->ti->error = "Can't takeover degraded raid set";
                return -EPERM;
@@ -1758,8 +1755,6 @@ static int rs_check_reshape(struct raid_set *rs)
 {
        struct mddev *mddev = &rs->md;
 
-       smp_rmb(); /* Make sure we access recent reshape position */
-
        if (!mddev->pers || !mddev->pers->check_reshape)
                rs->ti->error = "Reshape not supported";
        else if (mddev->degraded)