usb: musb: musbhsdma: drop the controller check in dma_controller_destroy()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 19 Jun 2013 15:38:10 +0000 (17:38 +0200)
committerFelipe Balbi <balbi@ti.com>
Mon, 29 Jul 2013 10:53:17 +0000 (13:53 +0300)
This check is hardly required and alas is wrong. 'c' might be NULL but
the chances are low that 'controller' after the container_of() becomes
NULL.

Since no other DMA implementation is doing that and musb-core does not
call it with a NULL pointer it can dropped.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/musb/musbhsdma.c

index 3d1fd52a15a9958f2256fc78b71a440b06e80a81..3f5e121dc15400e0bc5c23d6de840b3737ab85a9 100644 (file)
@@ -371,9 +371,6 @@ void dma_controller_destroy(struct dma_controller *c)
        struct musb_dma_controller *controller = container_of(c,
                        struct musb_dma_controller, controller);
 
-       if (!controller)
-               return;
-
        if (controller->irq)
                free_irq(controller->irq, c);