projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 06f824c)
skd: Remove a redundant init_timer() call
authorBart Van Assche <bart.vanassche@wdc.com>
Thu, 17 Aug 2017 20:13:16 +0000 (13:13 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 18 Aug 2017 14:45:29 +0000 (08:45 -0600)
Since setup_timer() invokes init_timer(), invoking init_timer()
just before setup_timer() is redundant. Hence remove the init_timer()
call.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/skd_main.c patch | blob | blame | history

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 62e06e35ddf55b54735529951424087f1c933bd7..71158e8b8a2bcc1469239e6c464b0ff1dd702add 100644 (file)
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1057,7 +1057,6 @@ static int skd_start_timer(struct skd_device *skdev)
 {
        int rc;
 
-       init_timer(&skdev->timer);
        setup_timer(&skdev->timer, skd_timer_tick, (ulong)skdev);
 
        rc = mod_timer(&skdev->timer, (jiffies + HZ));