usb: host: ohci-ppc-of: Fix refcount leak bug
authorLiang He <windhl@126.com>
Fri, 17 Jun 2022 03:46:37 +0000 (11:46 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:09:30 +0000 (11:09 +0200)
[ Upstream commit 40a959d7042bb7711e404ad2318b30e9f92c6b9b ]

In ohci_hcd_ppc_of_probe(), of_find_compatible_node() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220617034637.4003115-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/ohci-ppc-of.c

index 4f87a5c61b08501b8edfcf8322f48f32b5767f2f..d22a70363fbfd1ec5024b232389fa91be16a96a2 100644 (file)
@@ -168,6 +168,7 @@ static int ohci_hcd_ppc_of_probe(struct platform_device *op)
                                release_mem_region(res.start, 0x4);
                } else
                        pr_debug("%s: cannot get ehci offset from fdt\n", __FILE__);
+               of_node_put(np);
        }
 
        irq_dispose_mapping(irq);