IB/usnic: Fix out of bounds index check in query pkey
authorGal Pressman <galpress@amazon.com>
Mon, 7 Jan 2019 15:27:54 +0000 (17:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:10 +0000 (10:24 +0100)
[ Upstream commit 4959d5da5737dd804255c75b8cea0a2929ce279a ]

The pkey table size is one element, index should be tested for > 0 instead
of > 1.

Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
Signed-off-by: Gal Pressman <galpress@amazon.com>
Acked-by: Parvi Kaustubhi <pkaustub@cisco.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/hw/usnic/usnic_ib_verbs.c

index a5bfbba6bbac0e9d918462ebb37d041608b9d321..cacb720f44a02d6347dcb271e66a9c9313efed28 100644 (file)
@@ -425,7 +425,7 @@ int usnic_ib_query_gid(struct ib_device *ibdev, u8 port, int index,
 int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index,
                                u16 *pkey)
 {
-       if (index > 1)
+       if (index > 0)
                return -EINVAL;
 
        *pkey = 0xffff;