mdio_bus: use devm_gpiod_get_optional()

The MDIO reset GPIO is really a classical optional GPIO property case,
so devm_gpiod_get_optional() should have been used, not devm_gpiod_get().
Doing this  saves several LoCs...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 5d37716e779692367acd96ca87ed744403562043..2df7b62c1a36811e97087ae641a89d06641cef4e 100644 (file)
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -354,16 +354,12 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
        mutex_init(&bus->mdio_lock);
 
        /* de-assert bus level PHY GPIO reset */
-       gpiod = devm_gpiod_get(&bus->dev, "reset", GPIOD_OUT_LOW);
+       gpiod = devm_gpiod_get_optional(&bus->dev, "reset", GPIOD_OUT_LOW);
        if (IS_ERR(gpiod)) {
-               err = PTR_ERR(gpiod);
-               if (err != -ENOENT) {
-                       dev_err(&bus->dev,
-                               "mii_bus %s couldn't get reset GPIO\n",
-                               bus->id);
-                       return err;
-               }
-       } else  {
+               dev_err(&bus->dev, "mii_bus %s couldn't get reset GPIO\n",
+                       bus->id);
+               return PTR_ERR(gpiod);
+       } else  if (gpiod) {
                bus->reset_gpiod = gpiod;
 
                gpiod_set_value_cansleep(gpiod, 1);