net: PPPoPNS: Remove length argument from data_ready
authorJon Medhurst <tixy@linaro.org>
Wed, 19 Aug 2015 12:43:16 +0000 (13:43 +0100)
committerJohn Stultz <john.stultz@linaro.org>
Tue, 16 Feb 2016 21:51:21 +0000 (13:51 -0800)
The argument was removed by commit 676d23690fb6 ("net: Fix use after free by
removing length arg from sk_data_ready callbacks") and it's presence causes
warnings like:

drivers/net/ppp/pppopns.c:296:27: warning: assignment from incompatible pointer type
  po->proto.pns.data_ready = sk_raw->sk_data_ready;

Signed-off-by: Jon Medhurst <tixy@linaro.org>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
drivers/net/ppp/pppopns.c
include/linux/if_pppox.h

index 6016d29c0660c5bbb50e7baf13711a3fb663d6db..dc15f978c922ed20cd7036121a0ac72b4accca5e 100644 (file)
@@ -169,7 +169,7 @@ drop:
        return NET_RX_DROP;
 }
 
-static void pppopns_recv(struct sock *sk_raw, int length)
+static void pppopns_recv(struct sock *sk_raw)
 {
        struct sk_buff *skb;
        while ((skb = skb_dequeue(&sk_raw->sk_receive_queue))) {
index a487f87c2f09ae75b664785006998344f04fa405..63828a5870f1cec1d39939bf237f24b2750320b1 100644 (file)
@@ -58,7 +58,7 @@ struct pppopns_opt {
        __u16           remote;
        __u32           recv_sequence;
        __u32           xmit_sequence;
-       void            (*data_ready)(struct sock *sk_raw, int length);
+       void            (*data_ready)(struct sock *sk_raw);
        int             (*backlog_rcv)(struct sock *sk_raw, struct sk_buff *skb);
 };