perf tools: Remove redundant initialization of thread linkage members
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 22 May 2015 20:42:37 +0000 (17:42 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 27 May 2015 15:21:44 +0000 (12:21 -0300)
A thread moves from a rb tree to a list, but can't be on both, because
those linkage members are in a union. This is leftover from when I was
debugging thread refcounting and had nuked that union.

It is harmless duplication, as RB_CLEAR_NODE() does again what
INIT_LIST_HEAD does.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-hmma9lmip6qlhzhgkhp9tzd1@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/thread.c

index 16c28a37a9e4e0fbf4bb4f631f9d8212071c80ad..28c4b746baa19bef9830814c4fe7c69f1be0b06b 100644 (file)
@@ -54,7 +54,6 @@ struct thread *thread__new(pid_t pid, pid_t tid)
 
                list_add(&comm->list, &thread->comm_list);
                atomic_set(&thread->refcnt, 0);
-               INIT_LIST_HEAD(&thread->node);
                RB_CLEAR_NODE(&thread->rb_node);
        }
 
@@ -70,7 +69,6 @@ void thread__delete(struct thread *thread)
        struct comm *comm, *tmp;
 
        BUG_ON(!RB_EMPTY_NODE(&thread->rb_node));
-       BUG_ON(!list_empty(&thread->node));
 
        thread_stack__free(thread);