Bluetooth: Fix updating SMP remote key distribution information
authorJohan Hedberg <johan.hedberg@intel.com>
Fri, 14 Mar 2014 08:53:50 +0000 (10:53 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 14 Mar 2014 16:05:24 +0000 (09:05 -0700)
When performing pairing using SMP the remote may clear any key
distribution bits it wants in its pairing response. We must therefore
update our local variable accordingly, otherwise we might get stuck
waiting for keys that will never come.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/smp.c

index 74a17cf91b26d155450088784b73018d5cd45981..8a1b1bf7955544ac7abf7e81db44f651aaf433ff 100644 (file)
@@ -748,6 +748,11 @@ static u8 smp_cmd_pairing_rsp(struct l2cap_conn *conn, struct sk_buff *skb)
        smp->prsp[0] = SMP_CMD_PAIRING_RSP;
        memcpy(&smp->prsp[1], rsp, sizeof(*rsp));
 
+       /* Update remote key distribution in case the remote cleared
+        * some bits that we had enabled in our request.
+        */
+       smp->remote_key_dist &= rsp->resp_key_dist;
+
        if ((req->auth_req & SMP_AUTH_BONDING) &&
            (rsp->auth_req & SMP_AUTH_BONDING))
                auth = SMP_AUTH_BONDING;