[SUNSU]: Fix bogus locking in sunsu_change_mouse_baud()
authorDavid S. Miller <davem@davemloft.net>
Tue, 4 Oct 2005 00:37:27 +0000 (17:37 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Oct 2005 00:37:27 +0000 (17:37 -0700)
The lock is not held when calling this function, so we
shouldn't drop then reacquire it.

Based upon a report from Jim MacBaine.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/serial/sunsu.c

index 5959e6755a8149d4fd440592b2d6ae57fe25b929..656c0e8d160eac0dc9ee73fa5eea7bb903df050c 100644 (file)
@@ -518,11 +518,7 @@ static void sunsu_change_mouse_baud(struct uart_sunsu_port *up)
 
        quot = up->port.uartclk / (16 * new_baud);
 
-       spin_unlock(&up->port.lock);
-
        sunsu_change_speed(&up->port, up->cflag, 0, quot);
-
-       spin_lock(&up->port.lock);
 }
 
 static void receive_kbd_ms_chars(struct uart_sunsu_port *up, struct pt_regs *regs, int is_break)