Resolved a few TODOs

diff --git a/wcfsetup/install/files/lib/acp/form/UsersMassProcessingForm.class.php b/wcfsetup/install/files/lib/acp/form/UsersMassProcessingForm.class.php
index 8e9cbb998eec750e85a1fadaf8a481a98f713fcc..5ee0ac4873f463fe2f8f793156a455306511f7c9 100644 (file)
--- a/wcfsetup/install/files/lib/acp/form/UsersMassProcessingForm.class.php
+++ b/wcfsetup/install/files/lib/acp/form/UsersMassProcessingForm.class.php
@@ -301,7 +301,10 @@ class UsersMassProcessingForm extends UserOptionListForm {
        }
        
        /**
-        * @todo        add documentation
+        * Fetches a list of users.
+        * 
+        * @param       mixed           $loopFunction
+        * @return      array<integer>
         */
        protected function fetchUsers($loopFunction = null) {
                // select users

diff --git a/wcfsetup/install/files/lib/data/user/UserAction.class.php b/wcfsetup/install/files/lib/data/user/UserAction.class.php
index 84161e90598f8e0bd4100ab1cc124d84e7c8345f..2636c7e89926ddb8e8f186698310b882ddac8f5d 100644 (file)
--- a/wcfsetup/install/files/lib/data/user/UserAction.class.php
+++ b/wcfsetup/install/files/lib/data/user/UserAction.class.php
@@ -15,7 +15,7 @@ use wcf\util\StringUtil;
  * Executes user-related actions.
  * 
  * @author     Alexander Ebert
- * @copyright  2001-2012 WoltLab GmbH
+ * @copyright  2001-2013 WoltLab GmbH
  * @license    GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
  * @package    com.woltlab.wcf
  * @subpackage data.user
@@ -245,7 +245,7 @@ class UserAction extends AbstractDatabaseObjectAction implements IClipboardActio
                $sql = "SELECT  userID, username
                        FROM    wcf".WCF_N."_user
                        ".$conditionBuilder;
-               $statement = WCF::getDB()->prepareStatement($sql, 10); /* TODO: add limit parameter */
+               $statement = WCF::getDB()->prepareStatement($sql, 10);
                $statement->execute($conditionBuilder->getParameters());
                while ($row = $statement->fetchArray()) {
                        $list[] = array(

diff --git a/wcfsetup/install/files/lib/data/user/option/UserOption.class.php b/wcfsetup/install/files/lib/data/user/option/UserOption.class.php
index 421f7ab0eb84d4650bd33940c2f7d8e02dda895b..e1d9b875e103e8d8138f2dd2fc5f1c7971783151 100644 (file)
--- a/wcfsetup/install/files/lib/data/user/option/UserOption.class.php
+++ b/wcfsetup/install/files/lib/data/user/option/UserOption.class.php
@@ -151,8 +151,7 @@ class UserOption extends Option {
                }
                
                // check owner state
-               // TODO: Shouldn't this be: EDITABILITY_OWNER?
-               if ($this->editable & self::VISIBILITY_OWNER) {
+               if ($this->editable & self::EDITABILITY_OWNER) {
                        if ($this->user === null || $this->user->userID == WCF::getUser()->userID) {
                                return true;
                        }

diff --git a/wcfsetup/install/files/lib/system/request/RouteHandler.class.php b/wcfsetup/install/files/lib/system/request/RouteHandler.class.php
index c19297727d0d2400e7b16d228a6b9340bff2796b..0e10264333bc78804db8eb8a845af133de703a7e 100644 (file)
--- a/wcfsetup/install/files/lib/system/request/RouteHandler.class.php
+++ b/wcfsetup/install/files/lib/system/request/RouteHandler.class.php
@@ -73,8 +73,6 @@ class RouteHandler extends SingletonFactory {
        
        /**
         * Adds default routes.
-        * 
-        * @todo add support for custom default controllers (see https://github.com/WoltLab/WCF/issues/1000)
         */
        protected function addDefaultRoutes() {
                $acpRoute = new Route('ACP_default', true);