staging: sep: Fix sign of error
authorAlan Cox <alan@linux.intel.com>
Wed, 21 Mar 2012 12:32:32 +0000 (12:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Apr 2012 16:14:39 +0000 (09:14 -0700)
One of our errors wasn't negative as intended. Fix this.
(Found by Hillf Danton)

While we are at it turn user causable messages down to dev_dbg level in the
ioctl paths.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sep/sep_main.c

index ad54c2e5c9324b872b79cc82101eac0f7b0a6a13..f1701bc6e31238e2647be5edd8b58ea4ec4c1db9 100644 (file)
@@ -3114,7 +3114,7 @@ static long sep_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
                        current->pid);
                if (1 == test_bit(SEP_LEGACY_SENDMSG_DONE_OFFSET,
                                  &call_status->status)) {
-                       dev_warn(&sep->pdev->dev,
+                       dev_dbg(&sep->pdev->dev,
                                "[PID%d] dcb prep needed before send msg\n",
                                current->pid);
                        error = -EPROTO;
@@ -3122,9 +3122,9 @@ static long sep_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
                }
 
                if (!arg) {
-                       dev_warn(&sep->pdev->dev,
+                       dev_dbg(&sep->pdev->dev,
                                "[PID%d] dcb null arg\n", current->pid);
-                       error = EINVAL;
+                       error = -EINVAL;
                        goto end_function;
                }