fpga-manager: altera-ps-spi: use bitrev8x4
authorJoshua Clayton <stillcompiling@gmail.com>
Wed, 14 Jun 2017 15:36:32 +0000 (10:36 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Jul 2017 15:26:14 +0000 (17:26 +0200)
Speed up bit reversal by using hardware bit reversal
Add extra code to handle less than 4byte remnants, if any

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
Signed-off-by: Alan Tull <atull@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/fpga/altera-ps-spi.c

index 0db8def668ed4d8bed632dcd30a5ef62e0f09a0e..14f14efdf0d53ca23c24d7c514cdd4c4ad4b8174 100644 (file)
@@ -149,12 +149,23 @@ static int altera_ps_write_init(struct fpga_manager *mgr,
 
 static void rev_buf(char *buf, size_t len)
 {
-       const char *fw_end = (buf + len);
+       u32 *fw32 = (u32 *)buf;
+       size_t extra_bytes = (len & 0x03);
+       const u32 *fw_end = (u32 *)(buf + len - extra_bytes);
 
        /* set buffer to lsb first */
-       while (buf < fw_end) {
-               *buf = bitrev8(*buf);
-               buf++;
+       while (fw32 < fw_end) {
+               *fw32 = bitrev8x4(*fw32);
+               fw32++;
+       }
+
+       if (extra_bytes) {
+               buf = (char *)fw_end;
+               while (extra_bytes) {
+                       *buf = bitrev8(*buf);
+                       buf++;
+                       extra_bytes--;
+               }
        }
 }