UBIFS: fix remount error path
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 7 Apr 2014 10:39:06 +0000 (13:39 +0300)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 5 May 2014 06:31:33 +0000 (09:31 +0300)
Dan's "smatch" checker found out that there was a bug in the error path of the
'ubifs_remount_rw()' function. Instead of jumping to the "out" label which
cleans-things up, we just returned.

This patch fixes the problem.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
fs/ubifs/super.c

index a1266089eca1fc0054065dfc723e697daf5691e6..a81c7b556896115a4afbdea5452523057ccd195f 100644 (file)
@@ -1556,7 +1556,7 @@ static int ubifs_remount_rw(struct ubifs_info *c)
        if (c->space_fixup) {
                err = ubifs_fixup_free_space(c);
                if (err)
-                       return err;
+                       goto out;
        }
 
        err = check_free_space(c);