bonding: get netdev_rx_handler_unregister out of locks
authorVeaceslav Falico <vfalico@redhat.com>
Tue, 2 Apr 2013 05:15:16 +0000 (05:15 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 2 Apr 2013 16:05:28 +0000 (12:05 -0400)
Now that netdev_rx_handler_unregister contains synchronize_net(), we need
to call it outside of bond->lock, cause it might sleep. Also, remove the
already unneded synchronize_net().

Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c

index 6bbd90e1123c59c58329505537568a2ec2d5b9b0..a51241b2e62186b03b4958faa509c4cefc14d052 100644 (file)
@@ -1976,12 +1976,11 @@ static int __bond_release_one(struct net_device *bond_dev,
                return -EINVAL;
        }
 
+       write_unlock_bh(&bond->lock);
        /* unregister rx_handler early so bond_handle_frame wouldn't be called
         * for this slave anymore.
         */
        netdev_rx_handler_unregister(slave_dev);
-       write_unlock_bh(&bond->lock);
-       synchronize_net();
        write_lock_bh(&bond->lock);
 
        if (!all && !bond->params.fail_over_mac) {