usb: gadget: udc: atmel: Use dev_err() to display EP configuration error
authorCristian Birsan <cristian.birsan@microchip.com>
Fri, 7 Apr 2017 16:07:21 +0000 (19:07 +0300)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Tue, 11 Apr 2017 07:58:31 +0000 (10:58 +0300)
Use dev_err() to display EP configuration error to avoid silent failure.

Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/atmel_usba_udc.c

index 8bc0b52a36f7b5b6b0be05c6193d1480f543e62a..3ccc34176a5aabb43cc4ee0bba90efa6fb32f551 100644 (file)
@@ -1851,8 +1851,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
                 * but it's clearly harmless...
                 */
                if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED))
-                       dev_dbg(&udc->pdev->dev,
-                                "ODD: EP0 configuration is invalid!\n");
+                       dev_err(&udc->pdev->dev,
+                               "ODD: EP0 configuration is invalid!\n");
 
                /* Preallocate other endpoints */
                n = fifo_mode ? udc->num_ep : udc->configured_ep;
@@ -1860,8 +1860,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
                        ep = &udc->usba_ep[i];
                        usba_ep_writel(ep, CFG, ep->ept_cfg);
                        if (!(usba_ep_readl(ep, CFG) & USBA_EPT_MAPPED))
-                               dev_dbg(&udc->pdev->dev,
-                                "ODD: EP%d configuration is invalid!\n", i);
+                               dev_err(&udc->pdev->dev,
+                                       "ODD: EP%d configuration is invalid!\n", i);
                }
        }