ALSA: hda - Bind with i915 component before codec binding

We used a on-demand i915 component binding for IvyBridge and
SandyBridge HDMI codecs, but it has a potential problem of the nested
module loading.  For avoiding that situation, assure the i915 binding
happening at the controller driver level for PCH controller devices,
where the initialization is performed in a detached work, instead of
calling from the codec driver probe.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 01eb1dc7b5b3b5cf3c070a7656b81452890781e0..433a2df9edad2b3f5463fedee96e64ad0e33c056 100644 (file)
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1384,8 +1384,10 @@ static int azx_free(struct azx *chip)
        if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL) {
                if (hda->need_i915_power)
                        snd_hdac_display_power(bus, false);
-               snd_hdac_i915_exit(bus);
        }
+       if (chip->driver_type == AZX_DRIVER_PCH ||
+           (chip->driver_caps & AZX_DCAPS_I915_POWERWELL))
+               snd_hdac_i915_exit(bus);
        kfree(hda);
 
        return 0;
@@ -2201,16 +2203,9 @@ static int azx_probe_continue(struct azx *chip)
 
        hda->probe_continued = 1;
 
-       /* Request display power well for the HDA controller or codec. For
-        * Haswell/Broadwell, both the display HDA controller and codec need
-        * this power. For other platforms, like Baytrail/Braswell, only the
-        * display codec needs the power and it can be released after probe.
-        */
-       if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL) {
-               /* HSW/BDW controllers need this power */
-               if (CONTROLLER_IN_GPU(pci))
-                       hda->need_i915_power = 1;
-
+       /* bind with i915 if needed */
+       if (chip->driver_type == AZX_DRIVER_PCH ||
+           (chip->driver_caps & AZX_DCAPS_I915_POWERWELL)) {
                err = snd_hdac_i915_init(bus);
                if (err < 0) {
                        /* if the controller is bound only with HDMI/DP
@@ -2222,9 +2217,22 @@ static int azx_probe_continue(struct azx *chip)
                                dev_err(chip->card->dev,
                                        "HSW/BDW HD-audio HDMI/DP requires binding with gfx driver\n");
                                goto out_free;
-                       } else
-                               goto skip_i915;
+                       } else {
+                               /* don't bother any longer */
+                               chip->driver_caps &= ~AZX_DCAPS_I915_POWERWELL;
+                       }
                }
+       }
+
+       /* Request display power well for the HDA controller or codec. For
+        * Haswell/Broadwell, both the display HDA controller and codec need
+        * this power. For other platforms, like Baytrail/Braswell, only the
+        * display codec needs the power and it can be released after probe.
+        */
+       if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL) {
+               /* HSW/BDW controllers need this power */
+               if (CONTROLLER_IN_GPU(pci))
+                       hda->need_i915_power = 1;
 
                err = snd_hdac_display_power(bus, true);
                if (err < 0) {
@@ -2234,7 +2242,6 @@ static int azx_probe_continue(struct azx *chip)
                }
        }
 
- skip_i915:
        err = azx_first_init(chip);
        if (err < 0)
                goto out_free;

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 90e4ff87445e866088f39c11cddf1326e2ea4e4d..feed8e8de2afa14cad558cc8727ba7bc2592db14 100644 (file)
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -174,7 +174,6 @@ struct hdmi_spec {
        /* i915/powerwell (Haswell+/Valleyview+) specific */
        bool use_acomp_notifier; /* use i915 eld_notify callback for hotplug */
        struct i915_audio_component_audio_ops i915_audio_ops;
-       bool i915_bound; /* was i915 bound in this driver? */
 
        struct hdac_chmap chmap;
        hda_nid_t vendor_nid;
@@ -2234,8 +2233,6 @@ static void generic_spec_free(struct hda_codec *codec)
        struct hdmi_spec *spec = codec->spec;
 
        if (spec) {
-               if (spec->i915_bound)
-                       snd_hdac_i915_exit(&codec->bus->core);
                hdmi_array_free(spec);
                kfree(spec);
                codec->spec = NULL;
@@ -2607,21 +2604,17 @@ static int patch_i915_cpt_hdmi(struct hda_codec *codec)
        struct hdmi_spec *spec;
        int err;
 
-       /* no i915 component should have been bound before this */
-       if (WARN_ON(codec->bus->core.audio_component))
-               return -EBUSY;
+       /* requires i915 binding */
+       if (!codec->bus->core.audio_component) {
+               codec_info(codec, "No i915 binding for Intel HDMI/DP codec\n");
+               return -ENODEV;
+       }
 
        err = alloc_generic_hdmi(codec);
        if (err < 0)
                return err;
        spec = codec->spec;
 
-       /* Try to bind with i915 now */
-       err = snd_hdac_i915_init(&codec->bus->core);
-       if (err < 0)
-               goto error;
-       spec->i915_bound = true;
-
        err = hdmi_parse_codec(codec);
        if (err < 0)
                goto error;