scsi: ufs: remove unnecessary goto label
authorTiezhu Yang <kernelpatch@126.com>
Sat, 25 Jun 2016 04:35:22 +0000 (12:35 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 15 Jul 2016 19:44:45 +0000 (15:44 -0400)
When buff_ascii kmalloc failed, there is no need to call kfree, it
should return -ENOMEM directly, this patch fixes it.

Signed-off-by: Tiezhu Yang <kernelpatch@126.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 8e8989a1859bb4f9c0fc69a1874f735c0e767d5e..f08d41a2d70b73bd8be1f505807af26270528335 100644 (file)
@@ -2137,7 +2137,7 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 *buf,
                buff_ascii = kmalloc(ascii_len, GFP_KERNEL);
                if (!buff_ascii) {
                        err = -ENOMEM;
-                       goto out_free_buff;
+                       goto out;
                }
 
                /*
@@ -2156,7 +2156,6 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 *buf,
                                size - QUERY_DESC_HDR_SIZE);
                memcpy(buf + QUERY_DESC_HDR_SIZE, buff_ascii, ascii_len);
                buf[QUERY_DESC_LENGTH_OFFSET] = ascii_len + QUERY_DESC_HDR_SIZE;
-out_free_buff:
                kfree(buff_ascii);
        }
 out: