[media] media: usb: s2255: s2255drv: don't print error when allocating urb fails
authorWolfram Sang <wsa-dev@sang-engineering.com>
Thu, 11 Aug 2016 21:03:58 +0000 (18:03 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 24 Aug 2016 12:25:42 +0000 (09:25 -0300)
kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/s2255/s2255drv.c

index 43ba71a7d02b8f4fbe0619ca8fbdbcaf25019802..9458eb0ef66f4380e75fca04805c5451bea6d379 100644 (file)
@@ -2113,11 +2113,8 @@ static int s2255_start_readpipe(struct s2255_dev *dev)
        pipe_info->state = 1;
        pipe_info->err_count = 0;
        pipe_info->stream_urb = usb_alloc_urb(0, GFP_KERNEL);
-       if (!pipe_info->stream_urb) {
-               dev_err(&dev->udev->dev,
-                       "ReadStream: Unable to alloc URB\n");
+       if (!pipe_info->stream_urb)
                return -ENOMEM;
-       }
        /* transfer buffer allocated in board_init */
        usb_fill_bulk_urb(pipe_info->stream_urb, dev->udev,
                          pipe,
@@ -2290,10 +2287,8 @@ static int s2255_probe(struct usb_interface *interface,
        }
 
        dev->fw_data->fw_urb = usb_alloc_urb(0, GFP_KERNEL);
-       if (!dev->fw_data->fw_urb) {
-               dev_err(&interface->dev, "out of memory!\n");
+       if (!dev->fw_data->fw_urb)
                goto errorFWURB;
-       }
 
        dev->fw_data->pfw_data = kzalloc(CHUNK_SIZE, GFP_KERNEL);
        if (!dev->fw_data->pfw_data) {