libceph: allow STAT osd operations
authorAlex Elder <elder@inktank.com>
Fri, 8 Feb 2013 15:55:48 +0000 (09:55 -0600)
committerAlex Elder <elder@inktank.com>
Wed, 20 Feb 2013 01:14:03 +0000 (19:14 -0600)
Add support for CEPH_OSD_OP_STAT operations in the osd client
and in rbd.

This operation sends no data to the osd; everything required is
encoded in identity of the target object.

The result will be ENOENT if the object doesn't exist.  If it does
exist and no other error occurs the server returns the size and last
modification time of the target object as output data (in little
endian format).  The size is a 64 bit unsigned and the time is
ceph_timespec structure (two unsigned 32-bit integers, representing
a seconds and nanoseconds value).

This resolves:
    http://tracker.ceph.com/issues/4007

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
drivers/block/rbd.c
net/ceph/osd_client.c

index ff9e9255745cdfc09a5620b7e680d6962c810b04..09514d9d8a9748d785b3bd2cf6e82d2ca4dd909b 100644 (file)
@@ -1148,6 +1148,8 @@ struct ceph_osd_req_op *rbd_osd_req_op_create(u16 opcode, ...)
                if (opcode == CEPH_OSD_OP_WRITE)
                        op->payload_len = op->extent.length;
                break;
+       case CEPH_OSD_OP_STAT:
+               break;
        case CEPH_OSD_OP_CALL:
                /* rbd_osd_req_op_create(CALL, class, method, data, datalen) */
                op->cls.class_name = va_arg(args, char *);
@@ -1277,6 +1279,16 @@ static void rbd_osd_write_callback(struct rbd_obj_request *obj_request,
        obj_request_done_set(obj_request);
 }
 
+/*
+ * For a simple stat call there's nothing to do.  We'll do more if
+ * this is part of a write sequence for a layered image.
+ */
+static void rbd_osd_stat_callback(struct rbd_obj_request *obj_request,
+                               struct ceph_osd_op *op)
+{
+       obj_request_done_set(obj_request);
+}
+
 static void rbd_osd_req_callback(struct ceph_osd_request *osd_req,
                                struct ceph_msg *msg)
 {
@@ -1307,6 +1319,9 @@ static void rbd_osd_req_callback(struct ceph_osd_request *osd_req,
        case CEPH_OSD_OP_WRITE:
                rbd_osd_write_callback(obj_request, op);
                break;
+       case CEPH_OSD_OP_STAT:
+               rbd_osd_stat_callback(obj_request, op);
+               break;
        case CEPH_OSD_OP_CALL:
        case CEPH_OSD_OP_NOTIFY_ACK:
        case CEPH_OSD_OP_WATCH:
index b58748ec405d3933051f34f11cf67cef0bfbced0..39629b66f3b1d074a6aa8db21101a429033255b5 100644 (file)
@@ -220,6 +220,8 @@ static void osd_req_encode_op(struct ceph_osd_request *req,
        dst->op = cpu_to_le16(src->op);
 
        switch (src->op) {
+       case CEPH_OSD_OP_STAT:
+               break;
        case CEPH_OSD_OP_READ:
        case CEPH_OSD_OP_WRITE:
                dst->extent.offset =
@@ -255,7 +257,6 @@ static void osd_req_encode_op(struct ceph_osd_request *req,
                pr_err("unrecognized osd opcode %d\n", dst->op);
                WARN_ON(1);
                break;
-       case CEPH_OSD_OP_STAT:
        case CEPH_OSD_OP_MAPEXT:
        case CEPH_OSD_OP_MASKTRUNC:
        case CEPH_OSD_OP_SPARSE_READ: