Fix method return values
authorMatthias Schmidt <gravatronics@live.com>
Sat, 7 May 2016 13:45:03 +0000 (15:45 +0200)
committerMatthias Schmidt <gravatronics@live.com>
Sat, 7 May 2016 13:45:03 +0000 (15:45 +0200)
wcfsetup/install/files/lib/data/acp/session/ACPSessionEditor.class.php
wcfsetup/install/files/lib/system/CLIWCF.class.php
wcfsetup/install/files/lib/system/background/BackgroundQueueHandler.class.php
wcfsetup/install/files/lib/system/condition/TObjectUserCondition.class.php
wcfsetup/install/files/lib/system/package/plugin/AbstractPackageInstallationPlugin.class.php

index 7b107e39d2cbec6b5f0ded9b7564e69d52523702..470e4eb28a5b947b9768ccd131919fbf56f068e4 100644 (file)
@@ -39,7 +39,7 @@ class ACPSessionEditor extends DatabaseObjectEditor {
                        $parameters['userID'] = null;
                }
                
-               return parent::update($parameters);
+               parent::update($parameters);
        }
        
        /**
index f48f4a41d0473f0d7ddd2b2144ff4c7a57a089bb..c7b4cbfa252198cde4be30004d5a2ea3bb8c5659 100644 (file)
@@ -328,7 +328,7 @@ class CLIWCF extends WCF {
                if (WCF::getSession()->getPermission('admin.configuration.package.canUpdatePackage') && VERBOSITY >= -1 && !self::getArgvParser()->disableUpdateCheck) {
                        $updates = PackageUpdateDispatcher::getInstance()->getAvailableUpdates();
                        if (!empty($updates)) {
-                               $return = self::getReader()->println(count($updates) . ' update' . (count($updates) > 1 ? 's are' : ' is') . ' available');
+                               self::getReader()->println(count($updates) . ' update' . (count($updates) > 1 ? 's are' : ' is') . ' available');
                                
                                if (VERBOSITY >= 1) {
                                        $table = array(
index b457446b46f82f1afd7f81dc0fc4b49511b24a0c..fdda0bf0dd47d5678001d2df4fc17721c57ebd89 100644 (file)
@@ -38,7 +38,7 @@ class BackgroundQueueHandler extends SingletonFactory {
         * @see \wcf\system\background\BackgroundQueueHandler::enqueueAt()
         */
        public function enqueueIn($jobs, $time = 0) {
-               return self::enqueueAt($jobs, TIME_NOW + $time);
+               self::enqueueAt($jobs, TIME_NOW + $time);
        }
        
        /**
index 8f2afea58acc1b76e620fda4c7403a2bd19ba5a6..d14a1ec856b3e76cd0416b646185b11c43d12294 100644 (file)
@@ -19,6 +19,6 @@ trait TObjectUserCondition {
         * @inheritDoc
         */
        public function checkUser(Condition $condition, User $user) {
-               $this->checkObject($user, $condition->conditionData);
+               return $this->checkObject($user, $condition->conditionData);
        }
 }
index d6fc74dc30b75e5c42840f519f21029d34c13fa6..d48b6df7d3d0f4faadfc91b953750f64da742fd5 100644 (file)
@@ -69,7 +69,7 @@ abstract class AbstractPackageInstallationPlugin implements IPackageInstallation
                // call 'update' event
                EventHandler::getInstance()->fireAction($this, 'update');
                
-               return $this->install();
+               $this->install();
        }
        
        /**