ALSA: emux: Adjust four checks for null pointers
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 9 Aug 2017 07:22:42 +0000 (09:22 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 10 Aug 2017 15:55:12 +0000 (17:55 +0200)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/synth/emux/emux_seq.c

index 12acf18c5be4daf3eceb2ea5d1bda29cce3f6a55..fd6cbd439511d6355a7b2abde8a06167a8ff20ac 100644 (file)
@@ -99,7 +99,7 @@ snd_emux_init_seq(struct snd_emux *emu, struct snd_card *card, int index)
                sprintf(tmpname, "%s Port %d", emu->name, i);
                p = snd_emux_create_port(emu, tmpname, MIDI_CHANNELS,
                                         0, &pinfo);
-               if (p == NULL) {
+               if (!p) {
                        snd_printk(KERN_ERR "can't create port\n");
                        return -ENOMEM;
                }
@@ -151,7 +151,7 @@ snd_emux_create_port(struct snd_emux *emu, char *name,
        }
        p->chset.channels = kcalloc(max_channels, sizeof(*p->chset.channels),
                                    GFP_KERNEL);
-       if (p->chset.channels == NULL) {
+       if (!p->chset.channels) {
                snd_printk(KERN_ERR "no memory\n");
                kfree(p);
                return NULL;
@@ -373,7 +373,7 @@ int snd_emux_init_virmidi(struct snd_emux *emu, struct snd_card *card)
                return 0;
 
        emu->vmidi = kcalloc(emu->midi_ports, sizeof(*emu->vmidi), GFP_KERNEL);
-       if (emu->vmidi == NULL)
+       if (!emu->vmidi)
                return -ENOMEM;
 
        for (i = 0; i < emu->midi_ports; i++) {
@@ -405,7 +405,7 @@ int snd_emux_delete_virmidi(struct snd_emux *emu)
 {
        int i;
 
-       if (emu->vmidi == NULL)
+       if (!emu->vmidi)
                return 0;
 
        for (i = 0; i < emu->midi_ports; i++) {