ARM: entry: no need to check parent IRQ mask in IRQ handler return
authorRussell King <rmk+kernel@arm.linux.org.uk>
Sat, 25 Jun 2011 15:57:50 +0000 (16:57 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Wed, 29 Jun 2011 09:06:37 +0000 (10:06 +0100)
There's no point checking to see whether IRQs were masked in the parent
context when returning from IRQ handling - the fact that we're handling
an IRQ means that the parent context must have had IRQs unmasked.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/kernel/entry-armv.S

index 1e5f387c70ae04cc88bb15734a4b642f003948ae..fd42e667a81b4d1d183d1a9ed9052f6caddc2998 100644 (file)
@@ -234,8 +234,9 @@ __irq_svc:
 #endif
        ldr     r4, [sp, #S_PSR]                @ irqs are already disabled
 #ifdef CONFIG_TRACE_IRQFLAGS
-       tst     r4, #PSR_I_BIT
-       bleq    trace_hardirqs_on
+       @ The parent context IRQs must have been enabled to get here in
+       @ the first place, so there's no point checking the PSR I bit.
+       bl      trace_hardirqs_on
 #endif
        svc_exit r4                             @ return from exception
  UNWIND(.fnend         )