orangefs: generic_file_open() is pointless for character devices
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 19 Jan 2016 17:00:26 +0000 (12:00 -0500)
committerMike Marshall <hubcap@omnibond.com>
Sat, 23 Jan 2016 17:42:43 +0000 (12:42 -0500)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
fs/orangefs/devorangefs-req.c

index 5da5ef616b85c8c34f4e676c1d5db4e3ed63d00b..fb7f092f94ba69fdd8a009806c8e39957ffbfec6 100644 (file)
@@ -85,9 +85,8 @@ static int orangefs_devreq_open(struct inode *inode, struct file *file)
        mutex_lock(&devreq_mutex);
 
        if (open_access_count == 0) {
-               ret = generic_file_open(inode, file);
-               if (ret == 0)
-                       open_access_count++;
+               open_access_count++;
+               ret = 0;
        } else {
                DUMP_DEVICE_ERROR();
        }