ipmi/powernv: Fix error return code in ipmi_powernv_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 18 Jan 2018 01:43:19 +0000 (01:43 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Apr 2018 09:02:08 +0000 (11:02 +0200)
[ Upstream commit e749d328b0b450aa78d562fa26a0cd8872325dd9 ]

Fix to return a negative error code from the request_irq() error
handling case instead of 0, as done elsewhere in this function.

Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/ipmi/ipmi_powernv.c

index b338a4becbf8c72baa8a8e9b6b0396c1e6ee3c60..845efa0f724f03158696fd32426ca470b721adbc 100644 (file)
@@ -251,8 +251,9 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
                ipmi->irq = opal_event_request(prop);
        }
 
-       if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
-                               "opal-ipmi", ipmi)) {
+       rc = request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH,
+                        "opal-ipmi", ipmi);
+       if (rc) {
                dev_warn(dev, "Unable to request irq\n");
                goto err_dispose;
        }