skb: Use symbolic names for SCSI opcodes
authorBart Van Assche <bart.vanassche@wdc.com>
Thu, 17 Aug 2017 20:13:19 +0000 (13:13 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 18 Aug 2017 14:45:29 +0000 (08:45 -0600)
This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/skd_main.c

index ae66171ef10a74d20f1a763cd85cb70a8dfc9663..49e7097dd409c59a92cdbee4967ee18afa364efc 100644 (file)
@@ -473,9 +473,9 @@ skd_prep_rw_cdb(struct skd_scsi_request *scsi_req,
                unsigned count)
 {
        if (data_dir == READ)
-               scsi_req->cdb[0] = 0x28;
+               scsi_req->cdb[0] = READ_10;
        else
-               scsi_req->cdb[0] = 0x2a;
+               scsi_req->cdb[0] = WRITE_10;
 
        scsi_req->cdb[1] = 0;
        scsi_req->cdb[2] = (lba & 0xff000000) >> 24;
@@ -494,7 +494,7 @@ skd_prep_zerosize_flush_cdb(struct skd_scsi_request *scsi_req,
 {
        skreq->flush_cmd = 1;
 
-       scsi_req->cdb[0] = 0x35;
+       scsi_req->cdb[0] = SYNCHRONIZE_CACHE;
        scsi_req->cdb[1] = 0;
        scsi_req->cdb[2] = 0;
        scsi_req->cdb[3] = 0;
@@ -1880,7 +1880,8 @@ static void skd_complete_internal(struct skd_device *skdev,
                        }
                        dev_dbg(&skdev->pdev->dev,
                                "**** TUR failed, retry skerr\n");
-                       skd_send_internal_skspcl(skdev, skspcl, 0x00);
+                       skd_send_internal_skspcl(skdev, skspcl,
+                                                TEST_UNIT_READY);
                }
                break;
 
@@ -1896,7 +1897,8 @@ static void skd_complete_internal(struct skd_device *skdev,
                        }
                        dev_dbg(&skdev->pdev->dev,
                                "**** write buffer failed, retry skerr\n");
-                       skd_send_internal_skspcl(skdev, skspcl, 0x00);
+                       skd_send_internal_skspcl(skdev, skspcl,
+                                                TEST_UNIT_READY);
                }
                break;
 
@@ -1929,7 +1931,8 @@ static void skd_complete_internal(struct skd_device *skdev,
                        }
                        dev_dbg(&skdev->pdev->dev,
                                "**** read buffer failed, retry skerr\n");
-                       skd_send_internal_skspcl(skdev, skspcl, 0x00);
+                       skd_send_internal_skspcl(skdev, skspcl,
+                                                TEST_UNIT_READY);
                }
                break;