rtc: max77686: Properly handle regmap_irq_get_virq() error code
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Thu, 4 Feb 2016 00:26:35 +0000 (09:26 +0900)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 4 Feb 2016 22:44:14 +0000 (23:44 +0100)
The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions
but driver checked only for value of 0.

This could lead to a cast of -EINVAL to an unsigned int used as a
interrupt number for devm_request_threaded_irq(). Although this is not
yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but
might be a misleading when diagnosing errors.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq")
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-max77686.c

index bbb06dd2ee35f89149174a2182a506e4e0c455c2..d2d1176a1f6017b31443d4653f55170e0b6a56ae 100644 (file)
@@ -667,7 +667,7 @@ static int max77686_rtc_probe(struct platform_device *pdev)
 
        info->virq = regmap_irq_get_virq(max77686->rtc_irq_data,
                                         MAX77686_RTCIRQ_RTCA1);
-       if (!info->virq) {
+       if (info->virq <= 0) {
                ret = -ENXIO;
                goto err_rtc;
        }