watchdog: pic32-dmt: Fix return value check in pic32_dmt_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 17 Jun 2016 17:12:05 +0000 (17:12 +0000)
committerWim Van Sebroeck <wim@iguana.be>
Sun, 17 Jul 2016 19:01:49 +0000 (21:01 +0200)
In case of error, the function devm_kzalloc() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/pic32-dmt.c

index 962f58c03353b8541a7101920b207541b0e7fc89..5e8890eaa49f2d9f6b28a04c8f477bd747120ff7 100644 (file)
@@ -176,8 +176,8 @@ static int pic32_dmt_probe(struct platform_device *pdev)
        struct watchdog_device *wdd = &pic32_dmt_wdd;
 
        dmt = devm_kzalloc(&pdev->dev, sizeof(*dmt), GFP_KERNEL);
-       if (IS_ERR(dmt))
-               return PTR_ERR(dmt);
+       if (!dmt)
+               return -ENOMEM;
 
        mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        dmt->regs = devm_ioremap_resource(&pdev->dev, mem);