pm80xx: do not examine registers for iButton feature if ATTO adapter
authorBenjamin Rood <benjaminjrood@gmail.com>
Fri, 30 Oct 2015 14:53:29 +0000 (10:53 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 3 Nov 2015 04:39:35 +0000 (23:39 -0500)
ATTO adapters do not support this feature.  If the firmware fails to be
ready, it should not check the examined registers in order to examine
the state of the feature in order to prevent undefined behavior.

Signed-off-by: Benjamin Rood <brood@attotech.com>
Reviewed-by: Jack Wang <jinpu.wang@profitbricks.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm80xx_hwi.c

index 29c548be64386030ff850cc1dcbfbf31bf4c6b55..eb4fee61df729f700c8db790a632b9fe3b146324 100644 (file)
@@ -1267,6 +1267,8 @@ pm80xx_chip_soft_rst(struct pm8001_hba_info *pm8001_ha)
                /* check iButton feature support for motherboard controller */
                if (pm8001_ha->pdev->subsystem_vendor !=
                        PCI_VENDOR_ID_ADAPTEC2 &&
+                       pm8001_ha->pdev->subsystem_vendor !=
+                       PCI_VENDOR_ID_ATTO &&
                        pm8001_ha->pdev->subsystem_vendor != 0) {
                        ibutton0 = pm8001_cr32(pm8001_ha, 0,
                                        MSGU_HOST_SCRATCH_PAD_6);