drm/i915: Make semaphore modparam RO
authorBen Widawsky <benjamin.widawsky@intel.com>
Tue, 17 Dec 2013 23:06:42 +0000 (15:06 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 22 Jan 2014 08:58:26 +0000 (09:58 +0100)
A couple patches in the upcoming rework of semaphores will break if
semaphores are toggled by the user at various times. Since the code
cleanups there seem to be an overall win, and toggling semaphores at
runtime is not a terribly useful thing to do, simply make the module
parameter read-only.

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.c

index 43245b3fd2a22134986699bd89cff74e39c5d045..c99f571f1e84c1b5e4995f6b511d8ca7d86802aa 100644 (file)
@@ -59,7 +59,7 @@ MODULE_PARM_DESC(powersave,
                "Enable powersavings, fbc, downclocking, etc. (default: true)");
 
 int i915_semaphores __read_mostly = -1;
-module_param_named(semaphores, i915_semaphores, int, 0600);
+module_param_named(semaphores, i915_semaphores, int, 0400);
 MODULE_PARM_DESC(semaphores,
                "Use semaphores for inter-ring sync (default: -1 (use per-chip defaults))");