Remove obsolete handling of duplicated packages in PackageArchive::getExistingRequire...
authorTim Düsterhus <duesterhus@woltlab.com>
Tue, 15 Nov 2022 10:05:38 +0000 (11:05 +0100)
committerTim Düsterhus <duesterhus@woltlab.com>
Tue, 15 Nov 2022 10:06:25 +0000 (11:06 +0100)
`package` is a UNIQUE KEY in the database, the deleted logic was dead code.

wcfsetup/install/files/lib/system/package/PackageArchive.class.php

index 0362a0ac9d11720b9bae7574cf2f1913fbc3a604..4e79ab39100a9d883f455d7f590a7ef88cf2c763 100644 (file)
@@ -724,19 +724,7 @@ class PackageArchive
             $statement = WCF::getDB()->prepare($sql);
             $statement->execute($conditions->getParameters());
             while ($row = $statement->fetchArray()) {
-                if (!isset($existingPackages[$row['package']])) {
-                    $existingPackages[$row['package']] = [];
-                }
-
-                $existingPackages[$row['package']][$row['packageVersion']] = $row;
-            }
-
-            // sort multiple packages by version number
-            foreach ($existingPackages as $packageName => $instances) {
-                \uksort($instances, [Package::class, 'compareVersion']);
-
-                // get package with highest version number (get last package)
-                $existingPackages[$packageName] = \array_pop($instances);
+                $existingPackages[$row['package']] = $row;
             }
         }