thermal/drivers/exynos: Fix an error code in exynos_tmu_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 10 Aug 2021 08:44:13 +0000 (11:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Sep 2021 11:36:18 +0000 (13:36 +0200)
commit 02d438f62c05f0d055ceeedf12a2f8796b258c08 upstream.

This error path return success but it should propagate the negative
error code from devm_clk_get().

Fixes: 6c247393cfdd ("thermal: exynos: Add TMU support for Exynos7 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210810084413.GA23810@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thermal/samsung/exynos_tmu.c

index c974cb5fb9580b4b2fe6030e4348915f28ae6e70..02510c191c7dbda2c1b8c1beef8fd049665375d5 100644 (file)
@@ -1372,6 +1372,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
                data->sclk = devm_clk_get(&pdev->dev, "tmu_sclk");
                if (IS_ERR(data->sclk)) {
                        dev_err(&pdev->dev, "Failed to get sclk\n");
+                       ret = PTR_ERR(data->sclk);
                        goto err_clk;
                } else {
                        ret = clk_prepare_enable(data->sclk);