dm: mark request_queue dead before destroying the DM device
authorBart Van Assche <bart.vanassche@sandisk.com>
Wed, 31 Aug 2016 22:17:49 +0000 (15:17 -0700)
committerWilly Tarreau <w@1wt.eu>
Fri, 10 Feb 2017 10:04:08 +0000 (11:04 +0100)
commit 3b785fbcf81c3533772c52b717f77293099498d3 upstream.

This avoids that new requests are queued while __dm_destroy() is in
progress.

[js] use md->queue instead of non-present helper

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/md/dm.c

index f69fed826a564be1b40ed133a04b6c0de67ae84a..a77ef6cac62d336b6f41b644620138408ad7322c 100644 (file)
@@ -2323,6 +2323,7 @@ EXPORT_SYMBOL_GPL(dm_device_name);
 
 static void __dm_destroy(struct mapped_device *md, bool wait)
 {
+       struct request_queue *q = md->queue;
        struct dm_table *map;
 
        might_sleep();
@@ -2333,6 +2334,10 @@ static void __dm_destroy(struct mapped_device *md, bool wait)
        set_bit(DMF_FREEING, &md->flags);
        spin_unlock(&_minor_lock);
 
+       spin_lock_irq(q->queue_lock);
+       queue_flag_set(QUEUE_FLAG_DYING, q);
+       spin_unlock_irq(q->queue_lock);
+
        /*
         * Take suspend_lock so that presuspend and postsuspend methods
         * do not race with internal suspend.