buffer: make invalidate_bdev() drain all percpu LRU add caches
authorTejun Heo <tj@kernel.org>
Sat, 15 May 2010 18:09:27 +0000 (20:09 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Fri, 21 May 2010 18:01:02 +0000 (20:01 +0200)
invalidate_bdev() should release all page cache pages which are clean
and not being used; however, if some pages are still in the percpu LRU
add caches on other cpus, those pages are considered in used and don't
get released.  Fix it by calling lru_add_drain_all() before trying to
invalidate pages.

This problem was discovered while testing block automatic native
capacity unlocking.  Null pages which were read before automatic
unlocking didn't get released by invalidate_bdev() and ended up
interfering with partition scan after unlocking.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
fs/buffer.c

index c9c266db0624d73efaa487f664006d1bb862151b..08e422d5699674c246bf614d62fe826b6b0aaf43 100644 (file)
@@ -275,6 +275,7 @@ void invalidate_bdev(struct block_device *bdev)
                return;
 
        invalidate_bh_lrus();
+       lru_add_drain_all();    /* make sure all lru add caches are flushed */
        invalidate_mapping_pages(mapping, 0, -1);
 }
 EXPORT_SYMBOL(invalidate_bdev);